Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light client protocol #1511

Merged
merged 5 commits into from
Mar 8, 2023
Merged

light client protocol #1511

merged 5 commits into from
Mar 8, 2023

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Mar 6, 2023

Referenced issues

Description of the Change

  • Respond to light client protocol requests.
  • Fill optional BlockAnnounce fields for smoldot.

Benefits

  • Smoldot works.

Possible Drawbacks

@turuslan
light client protocol
e947985 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from Harrm and kamilsa March 6, 2023 11:36
Harrm
Harrm reviewed Mar 8, 2023
View reviewed changes
core/network/impl/protocols/light.hpp Show resolved Hide resolved
core/network/adapters/light.hpp Show resolved Hide resolved
core/network/adapters/light.hpp Outdated Show resolved Hide resolved
core/common/bytestr.hpp Outdated Show resolved Hide resolved
core/network/impl/protocols/light.cpp Show resolved Hide resolved
@turuslan
pr comment
3dedc4f 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
fix
f7c5e09 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from Harrm March 8, 2023 08:37
@turuslan
pr comment
aa90a5e 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit f6751c5 into master Mar 8, 2023
@turuslan turuslan deleted the feature/light-client-protocol branch March 8, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harrm Harrm Harrm approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @kamilsa @Harrm